Commander: Add land detection configuration to preflight checks #8618
Conversation
This should help to avoid having users which set up the land detector up for in-air land detection.
| bool success = true; // start with a pass and change to a fail if any test fails | ||
|
|
||
| // Check the relationship between land detection threshold and land speed | ||
| float land_speed, land_detect_speed; |
There was a problem hiding this comment.
That's true, but if that param is messed up on a fixed wing it would be equally disconcerting.
|
I'm wondering if it would be cleaner architecturally for the land detector (aka vehicle model) to report its status instead and have commander simply enforce the requirement (vehicle model is alive and reports healthy). Then we can avoid having to piece together the logic in a completely separate module. |
|
Yes, we should rework this PR to fulfil that. |
|
As we're aiming to fix cases like #8600 I want to mention that we also had these false positives for the first stage of landing detection resulting in very short thrust drops when the hover thrust configuration was completely off (was too high) because the land detector uses the parameters to set it's thresholds. I agree that having the checks in the same place would make it easier for the future. |
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
This should help to avoid having users which set up the land detector up for in-air land detection.
@PX4TestFlights Please test.