Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gyro/accel/mag raw values for SCALED_IMU mavlink msg #8517

Closed
wants to merge 9 commits into from

Conversation

ChristophTobler
Copy link
Contributor

We currently need to stream the raw/unfiltered gyro/accel values on the Snapdragon via Mavlink for VIO estimation (probably also on other platforms). Since the raw values don't seem to be used (was even inconsistent) I changed to to be the unfiltered values. There can then be streamed via the SCALED_IMU Mavlink msg.

Hopefully, I got all drivers...

@mhkabir
Copy link
Member

mhkabir commented Dec 22, 2017

Just curious - what's wrong with the values in HIGHRES_IMU? I've been using it for VIO for over a year now without any issues.

@ChristophTobler
Copy link
Contributor Author

ChristophTobler commented Dec 22, 2017

@mhkabir For two reasons:

  • Filtering adds a delay which is unwanted
  • Most VIOs use a EKF which already is a filter so it doesn't make much sense to prefilter it

We've tried using HIGHRES_IMU without any success on the Snapdragon with VISLAM. My assumption is VISLAM is very sensitive to delay/timestamps.

@LorenzMeier
Copy link
Member

LorenzMeier commented Dec 26, 2017

this looks like a valid short-term solution but the changes to all sensors are incomplete. I'm still pondering if this is the right incremental step or if we need something different (unfiltered, but correctly scaled values) across the board and rather should be doing that.

The current scaling does not have enough resolution to not introduce integration errors, which means its suboptimal for VIO and not viable long-term.

@ChristophTobler
Copy link
Contributor Author

@LorenzMeier I added the missing drivers (hopefully, I got them all).

I was wondering about the resolution as well. But what what do you mean with integration errors? Rounding errors? The thing is, it works reliably with VISLAM and therefore I'm not too worried.
Otherwise we would need to change the uorb msg or add a different one.

@LorenzMeier
Copy link
Member

@ChristophTobler The integration errors would not be visible in terms of diverging, but in terms of the convergence in EKF2 showing a constant error and the filter never converging fully to the right offset.

@ChristophTobler
Copy link
Contributor Author

Closing in favor of #8591 (temp hack) and new issue #8592

@ChristophTobler ChristophTobler deleted the pr-scaled_imu branch January 5, 2018 10:49
@dagar dagar mentioned this pull request Apr 10, 2018
@LorenzMeier
Copy link
Member

We are moving towards this interface for onboard companion communication: https://dev.px4.io/en/middleware/micrortps.html

@mcsauder
Copy link
Contributor

My apologies @ChristophTobler, I didn't mean to post that comment here... not sure how I managed to accomplish that. I'll delete it now so that it doesn't mislead future readers... Again, my apology.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants