Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a driver for the ADIS16448 IMU #8301

Merged
merged 25 commits into from
Nov 26, 2017
Merged

Conversation

ASM3
Copy link
Contributor

@ASM3 ASM3 commented Nov 16, 2017

This driver allows interfacing the AD's ADIS16448 IMU via the external SPI port and the usage of its gyroscope, accelerometer and magnetometer by using an adapter interface.

@dagar
Copy link
Member

dagar commented Nov 16, 2017

Overall looks good. What are the additional IOCTLs for?

@dagar
Copy link
Member

dagar commented Nov 16, 2017

CI failed due to style errors (run make format) and this pushed the px4fmu-v2_default over the flash limit. You could add it to px4fmu-v3_default and commented out in px4fmu-v2_default.

@ASM3
Copy link
Contributor Author

ASM3 commented Nov 17, 2017

for internal IMU settings (dynamic range, internal filter, sampling rate, etc)

@ASM3
Copy link
Contributor Author

ASM3 commented Nov 17, 2017

Additional IOCTLs where added for obtaining the device product ID, which is described with a unique product ID number of 0x4040 (16448) for configuration purpose.

@ASM3
Copy link
Contributor Author

ASM3 commented Nov 20, 2017

How come continuous-integration fails because of ADIS16448 driver on nuttx_px4fmu-v2_default? (ADIS16448 driver is commented out on px4fmu-v2_default)

MAIN adis16448
STACK_MAIN 1200
COMPILE_FLAGS
-Os
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the optimization setting.

@dagar
Copy link
Member

dagar commented Nov 21, 2017

Would you mind rebasing? There's been some churn in the driver layer to handle compatibility issues between all the pixhawk variants that were supposed to be binary compatible (but weren't).

src/drivers/device/spi.h moved to src/drivers/device/nuttx/SPI.hpp

Once it's rebased and CI is happy we can merge this immediately.

@ASM3 ASM3 force-pushed the feature/add_adis16448 branch from 0bb2f74 to fa4d8d6 Compare November 22, 2017 14:23
@dagar dagar merged commit a8787e8 into PX4:master Nov 26, 2017
@dagar
Copy link
Member

dagar commented Nov 26, 2017

Thanks!

@jinchengde
Copy link
Contributor

jinchengde commented Dec 12, 2017

that‘s looks great!
does it need to modify EKF anywhere?
@ASM3

@ASM3
Copy link
Contributor Author

ASM3 commented Dec 12, 2017

Yes I am currently working on this

@huotan
Copy link

huotan commented Dec 25, 2017

Impressive!
Look forward to your follow-up work。
@ASM3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants