-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a driver for the ADIS16448 IMU #8301
Conversation
Overall looks good. What are the additional IOCTLs for? |
CI failed due to style errors (run make format) and this pushed the px4fmu-v2_default over the flash limit. You could add it to px4fmu-v3_default and commented out in px4fmu-v2_default. |
for internal IMU settings (dynamic range, internal filter, sampling rate, etc) |
Additional IOCTLs where added for obtaining the device product ID, which is described with a unique product ID number of 0x4040 (16448) for configuration purpose. |
How come continuous-integration fails because of ADIS16448 driver on nuttx_px4fmu-v2_default? (ADIS16448 driver is commented out on px4fmu-v2_default) |
src/drivers/adis16448/CMakeLists.txt
Outdated
MAIN adis16448 | ||
STACK_MAIN 1200 | ||
COMPILE_FLAGS | ||
-Os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove the optimization setting.
Would you mind rebasing? There's been some churn in the driver layer to handle compatibility issues between all the pixhawk variants that were supposed to be binary compatible (but weren't). src/drivers/device/spi.h moved to src/drivers/device/nuttx/SPI.hpp Once it's rebased and CI is happy we can merge this immediately. |
0bb2f74
to
fa4d8d6
Compare
Thanks! |
that‘s looks great! |
Yes I am currently working on this |
Impressive! |
This driver allows interfacing the AD's ADIS16448 IMU via the external SPI port and the usage of its gyroscope, accelerometer and magnetometer by using an adapter interface.