Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ekf #8123

Merged
merged 4 commits into from
Oct 18, 2017
Merged

update ekf #8123

merged 4 commits into from
Oct 18, 2017

Conversation

ChristophTobler
Copy link
Contributor

@ChristophTobler ChristophTobler commented Oct 13, 2017

This PR includes the fix of #8102 and it uses the ground clearance parameter if the vehicle is on ground and out of range.

priseborough
priseborough previously approved these changes Oct 13, 2017
@priseborough
Copy link
Contributor

The code changes look OK, but the following mavros regression test failed:

http://sitl01.dronetest.io/job/PX4%20Firmware%20POSIX%20SITL%20PRs/7196/testReport/__main__/MavrosMissionTest/test_mission/

@ChristophTobler
Copy link
Contributor Author

There seem to be some issues with CI. Now sitl worked but travis didn't even though I didn't change anything... And semaphoreci is broken for a while it seems.

@dagar
Copy link
Member

dagar commented Oct 15, 2017

The semaphoreci failure is real. px4fmu-v2_default is out of flash again.
image

@davids5 can we remove mpu9250 from px4fmu-v2_default?

@ChristophTobler
Copy link
Contributor Author

@priseborough @dagar I've rebased this PR and now all checks have passed.

@dagar
Copy link
Member

dagar commented Oct 17, 2017

Good to go?

range_finder_updated = false;

} else {
range_finder.current_distance = _params->rng_gnd_clearance;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit picky, but on the Firmware side we should try to use the BlockParam interface for const access. _rng_gnd_clearance.get()
There's a mix of usage in ekf2_main so we can update them all later in a separate pass.

@priseborough
Copy link
Contributor

Can we bump the ecl reference to 61e0c04 so that it includes the position timeout bugfix?

@ChristophTobler
Copy link
Contributor Author

ChristophTobler commented Oct 18, 2017

Two test flights:
https://logs.px4.io/plot_app?log=0ec0d863-a41e-4594-8966-34b6f6465dcb
https://logs.px4.io/plot_app?log=7b9d66a9-8ed6-4f7b-abea-8361010d4f0a (with range aid)

Was working nicely! I also switched from flow to GPS + flow and back.
The only thing is that it is saying ekf2 and frsky_telemetry are low on stack (see log).

@LorenzMeier
Copy link
Member

Awesome!

@LorenzMeier LorenzMeier merged commit 85c076d into PX4:master Oct 18, 2017
@ChristophTobler ChristophTobler deleted the pr-update_ekf branch October 18, 2017 09:11
@priseborough
Copy link
Contributor

I've started on protection against flying the flow sensor outside of its speed and minimum focus distance here: https://github.com/PX4/ecl/tree/ekfPosCtrlLimits-wip and here: https://github.com/priseborough/Firmware/tree/ekfPosCtrlLimits-wip

I will submit a PR for these changes tomorrow. i did some testing today, but it was too windy to make a useful assessment. It works in SITL, but the controller changes need to be flown manually to get a better assessment as to whether the method of respecting the minimum height and max speed is acceptable from a UX point of view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants