-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ekf #8123
update ekf #8123
Conversation
The code changes look OK, but the following mavros regression test failed: |
157dd9a
to
f4b6671
Compare
There seem to be some issues with CI. Now sitl worked but travis didn't even though I didn't change anything... And semaphoreci is broken for a while it seems. |
The semaphoreci failure is real. px4fmu-v2_default is out of flash again. @davids5 can we remove mpu9250 from px4fmu-v2_default? |
f4b6671
to
b0e1ea2
Compare
@priseborough @dagar I've rebased this PR and now all checks have passed. |
Good to go? |
src/modules/ekf2/ekf2_main.cpp
Outdated
range_finder_updated = false; | ||
|
||
} else { | ||
range_finder.current_distance = _params->rng_gnd_clearance; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit picky, but on the Firmware side we should try to use the BlockParam interface for const access. _rng_gnd_clearance.get()
There's a mix of usage in ekf2_main so we can update them all later in a separate pass.
Can we bump the ecl reference to 61e0c04 so that it includes the position timeout bugfix? |
Two test flights: Was working nicely! I also switched from flow to GPS + flow and back. |
Awesome! |
I've started on protection against flying the flow sensor outside of its speed and minimum focus distance here: https://github.com/PX4/ecl/tree/ekfPosCtrlLimits-wip and here: https://github.com/priseborough/Firmware/tree/ekfPosCtrlLimits-wip I will submit a PR for these changes tomorrow. i did some testing today, but it was too windy to make a useful assessment. It works in SITL, but the controller changes need to be flown manually to get a better assessment as to whether the method of respecting the minimum height and max speed is acceptable from a UX point of view. |
This PR includes the fix of #8102 and it uses the ground clearance parameter if the vehicle is on ground and out of range.