Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

landdetector: remove outdated comment #8094

Merged
merged 1 commit into from
Oct 10, 2017

Conversation

Stifael
Copy link
Contributor

@Stifael Stifael commented Oct 9, 2017

related to land-detector PR, where the comment was not in sync with the current state.
I do not want to ignore the concern from @AndreasAntener here. However, since there are different ways to address the likelihood of falling out of landdetection during arming, I am currently hesitating to revert the old logic just because it was already in there and most likely not even necessary anymore because of the evolution of the landdetector

@codecov
Copy link

codecov bot commented Oct 9, 2017

Codecov Report

Merging #8094 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8094      +/-   ##
==========================================
+ Coverage   20.05%   20.09%   +0.04%     
==========================================
  Files         383      383              
  Lines       45600    45599       -1     
==========================================
+ Hits         9143     9162      +19     
+ Misses      36457    36437      -20
Flag Coverage Δ
#unittests 20.09% <ø> (+0.04%) ⬆️
Impacted Files Coverage Δ
.../modules/land_detector/MulticopterLandDetector.cpp 0% <ø> (ø) ⬆️
...c/platforms/posix/tests/muorb/muorb_test_example.h 50% <0%> (-50%) ⬇️
...rc/platforms/posix/tests/muorb/muorb_test_main.cpp 71.42% <0%> (-28.58%) ⬇️
...platforms/posix/tests/muorb/muorb_test_example.cpp 25.67% <0%> (-4.06%) ⬇️
src/modules/uORB/uORBDevices.cpp 46.5% <0%> (+0.11%) ⬆️
src/modules/uORB/uORBManager.cpp 53.37% <0%> (+1.12%) ⬆️
...forms/posix/tests/vcdev_test/vcdevtest_example.cpp 67.29% <0%> (+14.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1b970c...d3b9b5b. Read the comment docs.

@Stifael Stifael force-pushed the pr-landdetector_outdated_comment branch from d3b9b5b to b459726 Compare October 10, 2017 07:25
@Stifael Stifael merged commit 29cdb65 into master Oct 10, 2017
@Stifael Stifael deleted the pr-landdetector_outdated_comment branch October 10, 2017 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant