Free RAM on IO - Take 2 #7167
Merged
Free RAM on IO - Take 2 #7167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids burning significant memory in a configuration that is not actually using parallel tasks
This removes the unused input capture capabilities from the px4io and saves 128 bytes of ram.
Recover 16 bytes. Size of debug max message is 40 so limit the usart tx buffer to same size.
Closed
LorenzMeier
approved these changes
May 2, 2017
|
Nice! I had tinkered on a similar approach locally, it makes a lot more sense than my first stab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LorenzMeier
Free memory at "police light check" is 1656 bytes, that is 1056 up from master and up 176 bytes from pr-io-free-ram.
This has been tested on px4fmu-v2 (2 Mib) with Spektrum, and FrSky PPM and FrSky S Bus using QGC to check radio.
Based on your comment I refactored the first commit:
RC C library: Use same buffer as the protocols do not decode in parallel
There are now No code changes from master, other than file name refactoring and using a common struct. The only downside is that it that rc_common has to include all the other protocols.