Replace single if lines with brackets in astyle

[LorenzMeier]

This prevents us running into single if line errors. In particular with various contributors this is relevant.

[LorenzMeier]

An example change would be:

if (has_landed())
    disarm();
    power_down(); // <- this goes terribly wrong

astyle will change this to:

if (has_landed()) {
    disarm();
}
power_down(); // <- this goes terribly wrong, but now its obvious

[DrTon]

For me this is also good:

if (has_landed())
    disarm();
power_down(); // <- this goes terribly wrong, but now its obvious

Identation is more human readable than brackets. But maybe it's after python :)

[LorenzMeier]

Anton, Python is a good example: This here would execute both statements only if the if condition matches:

if (has_landed()):
    disarm();
    power_down(); // <- this works in Python

If you do the same indentation in C it will terribly fail - and yet you get used to it if you write a lot of Python code (or if you're not too familiar with C).

Its a beginners mistake, and yet people still fall for it.

[DrTon]

Sure, but astyle will shift last line back, isn't it?

[DrTon]

Ah, got it now. It's to avoid mistakes when modifying existing code, not for new code, right? Then brackets will really help!
+1

[LorenzMeier]

Yes, exactly - its to avoid that someone who adds a second line falls for it.

[julianoes]

Yep, I agree.

I ran into issues because of this several times, e.g. when commenting a line:

if (has_landed())
//    disarm();

do_next_thing();

Suddenly the do_next_thing() moves up into if...

[px4dev]

This applies equally to new code.

We should ensure that all pull requests have been fed through astyle before review.

[LorenzMeier]

Merging now. We will want to bring up some linting support into the online system. After the mixed TeamCity experience with QGroundControl I'm not sure yet which system / way to go, but I would want a bot commenting in Github with what he finds. Doing it on the local machines is just going to break the workflow.

[LorenzMeier]

I will try to bring this here up:
https://github.com/markstory/lint-review