CI: fix flash_analysis workflow on private forks #24404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch thanks, we are still working throughout all the failures this workflows has had in the last few weeks, hoping to get this working well everytime |
mrpollo
approved these changes
Feb 24, 2025
|
Unfortunately this doesn't fix the issue |
|
@dakejahl what error do you get? I tested it on our private fork and it fixed the issue for me. |
The error is the same. I disabled the check for now, but every PR from a fork has the same error.
Everything I've read online suggests using pull_request_target, with many mentions about commenting on PRs specifically. Sounds like Ramon will look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
This previous change explicitly set
pull-requests: writeandissues: write, but when defining custom permissions, GitHub removes all default permissions unless explicitly specified. This caused the workflow to fail with "Repository not found" on private forks becausecontents: readwas missing, preventing repository access for actions like checkout and git clone.