Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixedwing: fix wheel controller #24167

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Fixedwing: fix wheel controller #24167

merged 2 commits into from
Jan 3, 2025

Conversation

bresch
Copy link
Member

@bresch bresch commented Jan 3, 2025

Solved Problem

wheel control got broken in #22472

Solution

Use angular rate for yaw rate (wheel) control instead of yaw euler angle.

Test coverage

SITL test

@bresch bresch requested a review from sfuhrer January 3, 2025 11:33
@bresch bresch self-assigned this Jan 3, 2025
Copy link
Contributor

@sfuhrer sfuhrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find and thanks for the fix. I'm surprised that nobody hit the bug earlier.

@ryanjAA what PX4 version are you flying with currently?

@bresch bresch merged commit f1a339e into main Jan 3, 2025
60 of 61 checks passed
@bresch bresch deleted the pr-fw_wheel_ctrl branch January 3, 2025 14:07
@ryanjAA
Copy link
Contributor

ryanjAA commented Jan 3, 2025

@sfuhrer branched off at 1.14/.3 but no issues with wheel control.

@bresch
Copy link
Member Author

bresch commented Jan 3, 2025

Ok, the bug was introduced in 1.15, that's why. I'll make a patch for 1.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants