ina238: retry if read fails #24163
Merged
ina238: retry if read fails #24163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexKlimaj
force-pushed
the
pr-ina238-dont-publish-0
branch
2 times, most recently
from
8da3c6d to
c90e87e
Compare
dagar
reviewed
Jan 22, 2025
|
|
||
| if (ret == PX4_OK) { | ||
| data = swap16(received_bytes); | ||
| for (size_t i = 0; i < 6; i++) { |
There was a problem hiding this comment.
Why not use the actual _retries mechanism in I2C?
PX4-Autopilot/src/lib/drivers/device/nuttx/I2C.cpp
Lines 229 to 235 in e3b98e6
AlexKlimaj
force-pushed
the
pr-ina238-dont-publish-0
branch
from
c90e87e to
4a81e65
Compare
dagar
reviewed
Jan 22, 2025
dagar
reviewed
Jan 22, 2025
dagar
reviewed
Jan 22, 2025
dagar
reviewed
Jan 22, 2025
dagar
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticing some occasional dropouts of the data with the ARK 12s power modules. Same thing I found on the INA226 a couple of years ago. A single bad I2C read would cause the driver to publish 0's and not connected.
#19423
Needs to be tested on hardware.
Current behavior
