Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python dependency installation in CI #23991

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Fix python dependency installation in CI #23991

merged 2 commits into from
Nov 20, 2024

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Nov 20, 2024

Solved Problem

grafik

Solution

Try being less specific following https://peps.python.org/pep-0440/#version-specifiers

Test coverage

Let's see if that works 👀

@MaEtUgR MaEtUgR self-assigned this Nov 20, 2024
@PX4 PX4 deleted a comment from github-actions bot Nov 20, 2024
@MaEtUgR
Copy link
Member Author

MaEtUgR commented Nov 20, 2024

ok, at least we know for sure it's not empty version requirement dependent 🦶

@PX4 PX4 deleted a comment from github-actions bot Nov 20, 2024
@MaEtUgR MaEtUgR changed the title python requirements: less strict empy version specifier Fix python dependency installation in CI Nov 20, 2024
@MaEtUgR
Copy link
Member Author

MaEtUgR commented Nov 20, 2024

The second commit fixes the problem. I think it's because "setuptools" gets updated by the actions plugin we use but "packaging" is not updated. So I update that one manually just before that. Had the idea after reading pypa/setuptools#4496 (comment) The first commit is not necessary but would allow using patch releases like empty 3.3.5 which will likely not come out but who knows.

@PX4 PX4 deleted a comment from github-actions bot Nov 20, 2024
@MaEtUgR
Copy link
Member Author

MaEtUgR commented Nov 20, 2024

Can't get the other ones to pass but it's intermittent 😠 One CI issue solved, next pr for the next one.

@MaEtUgR MaEtUgR merged commit f8b34fd into main Nov 20, 2024
60 of 62 checks passed
@MaEtUgR MaEtUgR deleted the maetugr/empy-ci branch November 20, 2024 13:27
@mrpollo
Copy link
Contributor

mrpollo commented Nov 20, 2024

Thanks!, I had fixed this here too, #23962

@MaEtUgR
Copy link
Member Author

MaEtUgR commented Nov 21, 2024

@mrpollo Good that you had a look as well 👍
I wonder why your pr worked these update flags are true by default. Probably because you changed the container version and probably the version of the packaging package.

I made an upstream pr with my fix: py-actions/py-dependency-install#255
and tested it for us: #24016
Let's see what maintainers say 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants