Commander: fix wrong ack reporting for VEHICLE_CMD_EXTERNAL_POSITION_ESTIMATE #23642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnaly handled commands Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
haumarco
approved these changes
Sep 5, 2024
sfuhrer
deleted the
pr-commander-fix-ack-external_position_estimate-main
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
One ack from Commander (with VEHICLE_CMD_RESULT_UNSUPPORTED), and then one from EKF2 (with VEHICLE_CMD_RESULT_ACCEPTED). Gives you a warning in the GCS.
Solution
Add VEHICLE_CMD_EXTERNAL_POSITION_ESTIMATE to the list of commands that is not handled by Commander.
Changelog Entry
For release notes: