Change some 'RC' keywords to more appropriate 'manual_control' if also valid for joystick

[sfuhrer]

Most of all the arming/disarming reason should be "Stick gesture" and not "RC".

[MaEtUgR]

Thanks for bringing this up. The wording is actually wrong.
The only thing I'd do differently is take a term e.g. "stick gesture" and then use that term everywhere and not have the one enum "manual_control" and the UI string "stick" and another enum "rc" for the same thing.

I can add a suggestion.

[MaEtUgR]

@sfuhrer I thought "joystick gesture" is even more clear. What do you think?

[sfuhrer]

@sfuhrer I thought "joystick gesture" is even more clear. What do you think?

Not necessarily. I associate the word "joystick" to a gamepad generally, so a source for manual control inputs not being an RC. That's also how the groundstation tab is called:

So I would prefer to go back to "stick".

[sfuhrer]

Thanks for the add-ons @MaEtUgR !

[MaEtUgR]

associate the word "joystick" to a gamepad

You're right, that would be confusing again.

Just blew my mind how inaccurate humans including me usually are with wording 😄
How's a joystick a gamepad but not the stick of a remote? Does the prefix joy change it?
Because there were gameport "joystick"s for flight simulators in the 90s?
I digress 😇