Implemented temperature sensor support for INA228 / INA238 #23639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklaut
requested changes
Sep 4, 2024
niklaut
approved these changes
Sep 5, 2024
dagar
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
The INA228 and INA238 sensors have packaged temperature sensors. With this PR it is possible to use the temperature readings from these sensors. They are published in the field "temperature" of "BatteryStatus"
Solution
Changelog Entry
For release notes:
Alternatives
When we want to use the temperature measurements of those sensors there is no alternative.
Test coverage