Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add imu sensor for JFB110 #23626

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jfbblue0922
Copy link
Contributor

I added Murata's IMU sensor SCHA63T for JFB-110 and confirmed that the IMU was working properly.
I also required for operation added the JFB-110 board settings and minor FDCAN changes .

For additional features on the JFB-110 board, see #23622.

Thank you.

@jfbblue0922
Copy link
Contributor Author

@dagar

I have made a new PR, I would like you to check the contents of this PR.
Thank you.

@muramura
Copy link
Contributor

muramura commented Oct 8, 2024

I think it would be better to promote the MURATA IMU sensor separately.

ArduPilot's source code is under GPLv3. It is not permissible to reuse GPLv3 source code. Please perform the CRC calculation without using tables.

GPLV3 CODE
https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_Math/crc.cpp#L198

PR CODE
https://github.com/PX4/PX4-Autopilot/pull/23626/files#diff-591c3597a95704ea4a08afacca8030c3d3de5b2189b83f8064b12a455343e3d6R86

@muramura
Copy link
Contributor

muramura commented Oct 8, 2024

@dagar san

The Japanese company JAE has conducted tests using the JFB110 and has published comparative data.
They have performed tests using a dedicated test tool for FC.

Incorporating this FC into the PX4-Autopilot master will have the effect of promoting PX4-Autopilot in Japan.

https://www.jae.com/files/user/motion-sense-control/catalog/JFB-100_reference-material-ja.pdf

https://youtu.be/qOk35gpan_A?si=hx7KK252g5k1b6MB

https://youtu.be/qA1bgznHKpY?si=z9WjgqlvE7pI7QQZ

https://www.jae.com/Motion_Sensor_Control/eVTOL/FlightController/

@muramura
Copy link
Contributor

muramura commented Oct 9, 2024

@jfbblue0922 san

I cannot use the firmware upload mode in QGC. Even when specifying 'upload' in make and unplugging and replugging the USB connector, it doesn't proceed to the next action.

@muramura
Copy link
Contributor

muramura commented Oct 9, 2024

px_uploader.py is searching for the following device: /dev/serial/by-id/-Japan_Aviation_Electronics_Industry_Ltd._JFB-110

However, in defconfig, it is defined as: CONFIG_CDCACM_VENDORSTR="Japan Aviation Electronics Industry Ltd."

Please reduce the number of characters, including the bootloader.

Trying ['/dev/serial/by-id/-Japan_Aviation_Electronics_Indu_JFB-110', '/dev/serial/by-id/PX4_BL', '/dev/serial/by-id/BL_FMU', '/dev/serial/by-id/usb-The_Autopilot*', '/dev/serial/by-id/usb-Bitcraze*', '/dev/serial/by-id/pci-Bitcraze*', '/dev/serial/by-id/usb-Gumstix*', '/dev/serial/by-id/usb-Hex_ProfiCNC*', '/dev/serial/by-id/usb-UVify*', '/dev/serial/by-id/usb-ArduPilot*']
Trying /dev/serial/by-id/usb-Japan_Aviation_Electronics_Indu_JFB-110_BL_0-if00

Found board id: 1110,0 bootloader protocol revision 5 on /dev/serial/by-id/usb-Japan_Aviation_Electronics_Indu_JFB-110_BL_0-if00
Loaded firmware for board id: 1110,0 size: 1872740 bytes (95.25%)

Bootloader version: unknown
Sn: 003c001d3232511739303932
Chip: 20036450
Family: STM32H7[4|5]x
Revision: V
Flash: 1966080 bytes
Windowed mode: False

Erase : [====================] 100.0%
Program: [====================] 100.0%
Verify : [====================] 100.0%
Rebooting. Elapsed Time 29.968

muramura@ubuntu:~/JFB_PX4$

main rebase HEAD and JFB110 marged.
Screenshot from 2024-10-09 20-45-00

CONFIG_CDCACM_RXBUFSIZE=600
CONFIG_CDCACM_TXBUFSIZE=12000
CONFIG_CDCACM_VENDORID=0x0A8E
CONFIG_CDCACM_VENDORSTR="Japan Aviation Electronics Industry Ltd."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

px_uploader.py is searching for the following device: /dev/serial/by-id/-Japan_Aviation_Electronics_Industry_Ltd._JFB-110

However, in defconfig, it is defined as: CONFIG_CDCACM_VENDORSTR="Japan Aviation Electronics Industry Ltd."

Please reduce the number of characters, including the bootloader.

};

public:
uint8_t crc8_sae(const uint8_t *data, uint16_t length)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is believed to be borrowed from ArduPilot. ArduPilot is under the GPLv3 license. We cannot incorporate source code under the GPLv3 license.

There are methods that do not use tables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants