EKF2: ev-vel refactoring #23577
Open
EKF2: ev-vel refactoring #23577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bresch
requested changes
Aug 22, 2024
src/modules/ekf2/EKF/aid_sources/external_vision/ev_control.cpp
Outdated
Show resolved
Hide resolved
src/modules/ekf2/EKF/aid_sources/external_vision/ev_vel_control.cpp
Outdated
Show resolved
Hide resolved
src/modules/ekf2/EKF/aid_sources/external_vision/ev_vel_control.cpp
Outdated
Show resolved
Hide resolved
src/modules/ekf2/EKF/aid_sources/external_vision/ev_vel_control.cpp
Outdated
Show resolved
Hide resolved
haumarco
force-pushed
the
pr-ekf2_ev_refactoring
branch
from
0553791
to
1ab4db9
Compare
haumarco
force-pushed
the
pr-ekf2_ev_refactoring
branch
from
1ab4db9
to
b20282e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up EV-vel implementation.
I tried to keep controlEvVelFusion readable while defining the "sub-function" in individual classes based on the given velocity frame.
Alternative solution would be to have similar controlEvVelFusion functions for each frame...