Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global: Initialize the message variable #23560

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

muramura
Copy link
Contributor

Solved Problem

Inter-task message variables are being used without initialization.

Solution

Initialize the inter-task message variable.

Changelog Entry

None

Alternatives

None

Test coverage

None

Context

None

@muramura muramura changed the title Px4 initialize the message variable2 Initialize the message variable2 Aug 16, 2024
@muramura muramura changed the title Initialize the message variable2 Initialize the message variable Aug 16, 2024
@muramura muramura changed the title Initialize the message variable Global: Initialize the message variable Aug 16, 2024
Copy link
Member

@dagar dagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of this can be unnecessary when we know we're setting every field, but honestly it's probably still better to be safe than sorry.

@dagar
Copy link
Member

dagar commented Aug 26, 2024

How about skip PX4Accelerometer/PX4gyroscope? Those ones are published at quite a high rate (kilohertz) and we know every single field is being set.

@dagar
Copy link
Member

dagar commented Sep 4, 2024

Can you please discard 0f64d07 and 2eef867 and I'll merge the rest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants