mavlink_ftp: handle relative paths correctly #22980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkueng
force-pushed
the
mftp_relative_path
branch
from
0fc38b5 to
c190d9b
Compare
by ensuring there's a '/' in between when concatenating the path with _root_dir.
Prevents accessing invalid memory when reading ptr + oldpath_sz + 1 and oldpath_sz fills out the whole or N-1 bytes of the payload.
This would interfere with an existing ongoing session
bkueng
force-pushed
the
mftp_relative_path
branch
from
c190d9b to
019cf1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By ensuring there's a '/' in between when concatenating the path with _root_dir.
It turns out there's a bug in GQC where a component metadata uri like
mftp://etc/extras/component_general.json.xzis turned into an ftp request with path/etc/extras/component_general.json.xz, whereas it should beetc/extras/component_general.json.xz.