Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a 'rate' parameter in the xrce published topics to reduce the bandwidth #21716

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

negre
Copy link

@negre negre commented Jun 13, 2023

Solve Issue #19081

Solved Problem

Allow to set the maximal published rate of a given uxrce topic.

Fixes #19081

Solution

  • Add a parameter 'rate' in the file 'dds_topics.yaml'
  • Change the dds_topics.h.em template to save the last published time for configured topics and ignore the xrce publication if the time elapsed is too short when the uorb topics is updated.

Test coverage

SITL tested.

@mrpollo mrpollo requested a review from dagar June 13, 2023 14:37
@dagar
Copy link
Member

dagar commented Jun 13, 2023

Good idea, I've been thinking about doing this across the board with uORB::SubscriptionInterval, but I'm also worried about doing it in such a way it's going to scale to a large number of topics.

@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/reducing-data-rate-in-uxrce-dds/35837/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MicroRTPS bridge send rate
4 participants