-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROMFS: add motor assignment to holybro x500 #21349
Conversation
So with mine I had to switch to dshot300 for the protocol before it would fully work correctly. Without that one of my motors wouldn't spin up at the same time as the others. But in reality I'm just poking around in the dark here. I'm a hardware moron. You'd have to ask the Holybro folks what is correct. Although mine is working now I don't know if I have it set to what it really should be. |
I'd be surprised if PWM didn't work, but if we can use dshot, even better. According to the docs it's the FMU outputs. |
If this is updated, I'd recommend also updating the docs for the v2 version: https://docs.px4.io/main/en/frames_multicopter/holybro_x500v2_pixhawk6c.html |
Mine are like this. Nut keep in mind I don't know what I'm doing:
Originally when not using dshot I had to bump the min pwm to 1100 to get them to spin. Not sure if that's needed with dshot. |
The airframe is specifically listed as "Holybro X500 V2". |
@DonLakeFlyer in master we only have the X500 V2 though. However I just tested it and can confirm that the old one also supports dshot as well. |
@bkueng afaik FMU usually doesn't support dshot? So update the docs to connect them to AUX? |
@DonLakeFlyer the min pwm is not needed with dshot. The actuators page actually removes that setting once you switch to dshot. |
aced5f1
to
4098878
Compare
I updated the PR and added a note on the user guide: PX4/PX4-user_guide#2386 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @bkueng
@bkueng Thank for the PR. If we change it to FMU PWM Out as default for this airframe now, there will be users that will be confused on why their quad don't work when they update to 1.14. What is the reason that we remove these from rc.mc_defaults?, it looks the reason users are having issue with motor not spinning when armed is because of the PWM_Main_Min being too low? in 1.13 rc.mc_defaults, we have these as default. |
I don't mind changing but then we also need to change the docs: https://docs.px4.io/main/en/frames_multicopter/holybro_x500_pixhawk4.html#assembly The PWM_MIN is currently being addressed in #21513 |
@bkueng Can we change it back so that when existing user flash 1.14, they would not run into issue with this?
cc @julianoes |
Yes, can you update the documentation? |
@bkueng thanks! Yes. Will do after the change. |
No description provided.