Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROMFS: add motor assignment to holybro x500 #21349

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Conversation

bkueng
Copy link
Member

@bkueng bkueng commented Mar 22, 2023

No description provided.

@DonLakeFlyer
Copy link
Contributor

So with mine I had to switch to dshot300 for the protocol before it would fully work correctly. Without that one of my motors wouldn't spin up at the same time as the others.

But in reality I'm just poking around in the dark here. I'm a hardware moron. You'd have to ask the Holybro folks what is correct. Although mine is working now I don't know if I have it set to what it really should be.

@bkueng
Copy link
Member Author

bkueng commented Mar 23, 2023

I'd be surprised if PWM didn't work, but if we can use dshot, even better. According to the docs it's the FMU outputs.
Can you show your param diff? param show-for-airframe

@danielhonies
Copy link
Contributor

If this is updated, I'd recommend also updating the docs for the v2 version: https://docs.px4.io/main/en/frames_multicopter/holybro_x500v2_pixhawk6c.html
https://docs.px4.io/main/en/frames_multicopter/holybro_x500V2_pixhawk5x.html
Right now it says "Assign actuator functions to outputs to match your wiring." Probably add a note there to make clear it's preconfigured. Also if we move to dshot we should check if the old x500 comes with dshot capable ESCs.

@DonLakeFlyer
Copy link
Contributor

Mine are like this. Nut keep in mind I don't know what I'm doing:

param set-default PWM_AUX_FUNC1 101
param set-default PWM_AUX_FUNC2 102
param set-default PWM_AUX_FUNC3 103
param set-default PWM_AUX_FUNC4 104
param set-default PWM_AUX_MIN1 1100
param set-default PWM_AUX_MIN2 1100
param set-default PWM_AUX_MIN3 1100
param set-default PWM_AUX_MIN4 1100
param set-default PWM_AUX_TIM0 -4

Originally when not using dshot I had to bump the min pwm to 1100 to get them to spin. Not sure if that's needed with dshot.

@DonLakeFlyer
Copy link
Contributor

Also if we move to dshot we should check if the old x500 comes with dshot capable ESCs.

The airframe is specifically listed as "Holybro X500 V2".

@danielhonies
Copy link
Contributor

@DonLakeFlyer in master we only have the X500 V2 though. However I just tested it and can confirm that the old one also supports dshot as well.

@danielhonies
Copy link
Contributor

@bkueng afaik FMU usually doesn't support dshot? So update the docs to connect them to AUX?

@danielhonies
Copy link
Contributor

@DonLakeFlyer the min pwm is not needed with dshot. The actuators page actually removes that setting once you switch to dshot.

@bkueng
Copy link
Member Author

bkueng commented Mar 27, 2023

I updated the PR and added a note on the user guide: PX4/PX4-user_guide#2386

@mrpollo mrpollo self-requested a review March 28, 2023 15:17
Copy link
Contributor

@mrpollo mrpollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bkueng

@mrpollo mrpollo merged commit 932b743 into main Mar 28, 2023
@mrpollo mrpollo deleted the holybro_x500_motor_assign branch March 28, 2023 15:18
@vincentpoont2
Copy link
Member

vincentpoont2 commented May 3, 2023

@bkueng Thank for the PR.
However, I want to point out most existing user are probably using X500 v2 with the I/O PWM Out (Main PWM) because the I/O PWM Out was the default for all Quad airframe prior to the purging of the mixing stystem that was made in 1.14.

If we change it to FMU PWM Out as default for this airframe now, there will be users that will be confused on why their quad don't work when they update to 1.14.

What is the reason that we remove these from rc.mc_defaults?, it looks the reason users are having issue with motor not spinning when armed is because of the PWM_Main_Min being too low?

in 1.13 rc.mc_defaults, we have these as default.
param set-default PWM_MAIN_MAX 1950
param set-default PWM_MAIN_MIN 1075
param set-default PWM_MAIN_RATE 400

@bkueng
Copy link
Member Author

bkueng commented May 8, 2023

I don't mind changing but then we also need to change the docs: https://docs.px4.io/main/en/frames_multicopter/holybro_x500_pixhawk4.html#assembly

The PWM_MIN is currently being addressed in #21513

@vincentpoont2
Copy link
Member

@bkueng Can we change it back so that when existing user flash 1.14, they would not run into issue with this?

I want to point out most existing user are probably using X500 v2 with the I/O PWM Out (Main PWM) because the I/O PWM Out was the default for all Quad airframe prior to the purging of the mixing stystem that was made in 1.14.
If we change it to FMU PWM Out as default for this airframe now, there will be users that will be confused on why their quad don't work when they update to 1.14.

cc @julianoes

@bkueng
Copy link
Member Author

bkueng commented Jul 11, 2023

Yes, can you update the documentation?

@vincentpoont2
Copy link
Member

@bkueng thanks! Yes. Will do after the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants