-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore old mission if a new mission is not feasible #18255
Restore old mission if a new mission is not feasible #18255
Conversation
What worries me about this solution is that the GCS is currently oblivious to the mission and has this assumption of being in sync. Is this correct?
Let's at least pause to get a rough plan in place for resolving this fully in the near future. |
This is correct, but it is not that bad and changes should probably be done on the GCS side. Options:
In either way, I think it is better to have something so you can trigger RTL or LAND rather than have a vehicle in the air without a feasible mission. Edit: |
27ca85f
to
ce301a1
Compare
Closing this PR. In dev call was suggested a different approach where mission feasibility will be refactored to do validation more closely to mavlink level. Everyone else who currently care more about the vehicle has a valid mission and to be capable of land and return to home, the branch is here: https://github.com/PX4/PX4-Autopilot/tree/pr-restore_old_mission_if_a_new_missionis_not_feasible |
Describe problem solved by this pull request
This solves the issue described here #12473
Describe your solution
Dataman has space to store 2 missions. This solution will keep one valid mission in Dataman while other space will be used to store new missions. If the new mission is not feasible, it will return to a previously feasible mission.
This solution also includes fixes that were raised when after this feature was implemented.
Test data / coverage
It is tested in simulation and real vehicles for the last 6 months.