Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed all 'NED board' references to 'FRD body'. Also cleaned up mix… #16337

Closed
wants to merge 3 commits into from
Closed

Conversation

rblilja
Copy link
Contributor

@rblilja rblilja commented Dec 6, 2020

…ing of m/s/s and m/s^2 to use the latter. There are still some messages that needs to be looked at for correct reference frame: 'vehicle_rates_setpoint.msg' and 'vehicle_attitude_setpoint.msg

Solves issue: #16328

…ing of m/s/s and m/s^2 to use the latter. There are still some messages that needs to be looked at for correct reference frame: 'vehicle_rates_setpoint.msg' and 'vehicle_attitude_setpoint.msg
@rblilja rblilja marked this pull request as ready for review December 6, 2020 10:23
@dagar
Copy link
Member

dagar commented Dec 6, 2020

There are conflicts in quite a few files, can you rebase this on current master?

float32[3] accel_scale_2 # accelerometer XYZ scale factors in the sensor frame

# Corrections for barometric pressure outputs where corrected_pressure = raw_pressure * pressure_scale + pressure_offset
# Note the corrections are in the sensor frame and must be applied before the sensor data is rotated into body frame
# corrections for uORB instance 0
float32 baro_offset_0 # barometric pressure offsets in the sensor frame in m/s/s
float32 baro_offset_0 # barometric pressure offsets in the sensor frame in m/s^2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
float32 baro_offset_0 # barometric pressure offsets in the sensor frame in m/s^2
float32 baro_offset_0 # barometric pressure offsets in the sensor frame in Pascals.

@rblilja
Copy link
Contributor Author

rblilja commented Dec 6, 2020

There are conflicts in quite a few files, can you rebase this on current master?

@dagar I added current master as upstream and rebased my fork. Then pushed my origin to my fork master. Does that suffice? Sorry - I'm new to rebasing.

@dagar
Copy link
Member

dagar commented Dec 6, 2020

There are conflicts in quite a few files, can you rebase this on current master?

@dagar I added current master as upstream and rebased my fork. Then pushed my origin to my fork master. Does that suffice? Sorry - I'm new to rebasing.

Yes that would be fine, but it doesn't look like that branch made it to github as it still reports the conflicts.

Screen Shot 2020-12-06 at 1 32 13 PM

Merging with latest PX4 master is also fine.

@rblilja
Copy link
Contributor Author

rblilja commented Dec 6, 2020

@dagar Got messy. Closing this one and making a fresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants