Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlightTaskOffboard: fix header comment #14684

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Apr 16, 2020

Describe problem solved by this pull request
I guess Dennis didn't change it after copying the file skeleton...

@dagar
Copy link
Member

dagar commented Apr 16, 2020

What purpose do these comments serve?

@dagar dagar merged commit 630af7f into master Apr 16, 2020
@dagar dagar deleted the trivial-header-comment-fix branch April 16, 2020 18:38
@julianoes
Copy link
Contributor

My view is to delete comments like that. They are not helpful and often wrong anyway.

@MaEtUgR
Copy link
Member Author

MaEtUgR commented Apr 17, 2020

ok, let's use that as our guideline. In my opinion the @brief and @author are helpful but @file wasn't of any use to me before. I guess it just gets copied in the believe it's common practise. But if they don't contain any useful information I agree we can delete them 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants