commander: add check for VTOL airfame on fmu-v2 #14633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively we could have it as just a message which is sent every few seconds but I thought preventing a user from arming is safer. |
LorenzMeier
previously requested changes
Apr 9, 2020
MaEtUgR
reviewed
Apr 9, 2020
julianoes
dismissed
LorenzMeier’s stale review
The string does not get truncated. I tested it with the latest QGC release.
|
@dagar feel free to merge if you think this is good enough. |
This adds a preflight check when a VTOL airframe is configured on a fmu-v2 where VTOL is no longer included.
julianoes
force-pushed
the
pr-fmu-v2-vtol-warning
branch
from
ee2b397 to
28b5527
Compare
|
Rebased and fixed conflicts, ready to be merged. |
LorenzMeier
approved these changes
Apr 15, 2020
|
Not to be too negative, but are we sure it's worth even having the URL like this? The # is missing between bootloader and the way it's split onto the 2nd line ( |
|
We should create a PR or issue to QGC to fix the |
bkueng
pushed a commit
that referenced
this pull request
May 19, 2020
* commander: add check for VTOL airfame on fmu-v2 This adds a preflight check when a VTOL airframe is configured on a fmu-v2 where VTOL is no longer included. * commander: address code review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a preflight check when a VTOL airframe is configured on a fmu-v2 where VTOL is no longer included.
Resolves #14381.