-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flight termination: lockdown if failure is detected on takeoff #14428
Conversation
@hamishwillee The documentation for flight termination is here but where exactly should we mention that the failure detector is active during the first few seconds after takeoff even if the circuit-breaker is set? Should it be just a "note" and a modification of the diagram? |
Hi @bresch
In any case, first I'd suggest we update the text in Safety > Failure Detector. Perhaps replace the existing note with.
For the flight termination doc I would change the first pullet point under the software configuration heading to:
Updating diagram would be good. Perhaps you could just add a text where shown saying something like "(After takeoff complete)" where marked? |
So it would trigger a parachute? |
@bkueng It triggers flight termination, so if you have flight termination associated with a parachute trigger, yes. Should we trigger a "manual lockdown" (aka: kill) ? |
I'm scared that this will lead to false positives where we trigger termination after having taken off successfully within 5 seconds. Which detectors are used here and how sensitive are they? |
@julianoes By default, it's the tilt limit of 60 degrees (defined by FD_FAIL_P). We can reduce the 5s period or increase the default if required, but I've never seen a false detection in any of our flights |
Ok, which means this won't work when flying acro, and maybe planes. |
@julianoes Correct, the failure detector is not active in acro, rattitude and FW manual modes |
@bresch I don't think termination is the right choice here. I would limit to 3 seconds or less and lock the system down rather than triggering termination. Otherwise we will have parachute deployments on the ground and some of them are kinetic (explosives). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be a lockdown without termination (the architecture enables that) and a shorter period to make sure we've not left the ground.
During the first few seconds after takeoff, the failure detector is allowed to trigger motor lockdown. This is done for safety reasons to detect tipping-over or unstable tuning gains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok!
@bresch Did you make the changes needed in docs for this? i.e. as discussed in #14428 (comment) Did this end up being "flight termination" or some other action? Still triggered by the failure detector? |
During the first few seconds after takeoff, the failure detector is allowed to trigger motor lockdown.
This is done for safety reasons to detect tipping-over or unstable tuning gains.
SITL test: takeoff with unstable gains
https://logs.px4.io/plot_app?log=b43c05ec-0330-414a-b069-41309ce13cf5
FYI @Jaeyoung-Lim