Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flight termination: lockdown if failure is detected on takeoff #14428

Merged
merged 2 commits into from
Mar 23, 2020

Conversation

bresch
Copy link
Member

@bresch bresch commented Mar 19, 2020

During the first few seconds after takeoff, the failure detector is allowed to trigger motor lockdown.
This is done for safety reasons to detect tipping-over or unstable tuning gains.

SITL test: takeoff with unstable gains
https://logs.px4.io/plot_app?log=b43c05ec-0330-414a-b069-41309ce13cf5

FYI @Jaeyoung-Lim

@bresch bresch added this to the Release v1.11.0 milestone Mar 19, 2020
@bresch bresch requested a review from julianoes March 19, 2020 13:26
@bresch bresch self-assigned this Mar 19, 2020
@bresch
Copy link
Member Author

bresch commented Mar 19, 2020

@hamishwillee The documentation for flight termination is here but where exactly should we mention that the failure detector is active during the first few seconds after takeoff even if the circuit-breaker is set? Should it be just a "note" and a modification of the diagram?

@hamishwillee
Copy link
Contributor

Hi @bresch

  • Is the whole failure detector enabled on takeoff or just the attitude trigger? i.e. could an ATS still trigger on takeoff with the circuit breaker enabled?
  • Is the failure detector enabled before arming, or after arming before takeoff?

In any case, first I'd suggest we update the text in Safety > Failure Detector. Perhaps replace the existing note with.

Note Failure detection is always enabled for the first few seconds after takeoff. It can be enabled/disabled in flight using the CBRK_FLIGHTTERM=0 circuit breaker.

For the flight termination doc I would change the first pullet point under the software configuration heading to:

  • Enable the failure detector during flight by setting CBRK_FLIGHTTERM=0 (disabled by default).

    Note The failure detector active for a few seconds after takeoff, irrespective of the value of CBRK_FLIGHTTERM (in order to detect the vehicle tipping during launch).

Updating diagram would be good. Perhaps you could just add a text where shown saying something like "(After takeoff complete)" where marked?

image

@bkueng
Copy link
Member

bkueng commented Mar 20, 2020

So it would trigger a parachute?

@hamishwillee
Copy link
Contributor

hamishwillee commented Mar 20, 2020

@bkueng Good question. I would assume so if set up to do so in flight termination. @bresch ?

@bresch
Copy link
Member Author

bresch commented Mar 20, 2020

@bkueng It triggers flight termination, so if you have flight termination associated with a parachute trigger, yes. Should we trigger a "manual lockdown" (aka: kill) ?
I thought this wasn't a big issue because most of the new setups that would benefit from this feature won't have a parachute for their first flight, and even if it triggers it, you would have this as well with an external flight termination system. However, I agree that a simple kill would be enough because the parachute will most of the times not help, except if the drone shoots in the sky fast enough.

@julianoes
Copy link
Contributor

I'm scared that this will lead to false positives where we trigger termination after having taken off successfully within 5 seconds. Which detectors are used here and how sensitive are they?

@bresch
Copy link
Member Author

bresch commented Mar 20, 2020

@julianoes By default, it's the tilt limit of 60 degrees (defined by FD_FAIL_P). We can reduce the 5s period or increase the default if required, but I've never seen a false detection in any of our flights

@julianoes
Copy link
Contributor

Ok, which means this won't work when flying acro, and maybe planes.

@bresch
Copy link
Member Author

bresch commented Mar 20, 2020

@julianoes Correct, the failure detector is not active in acro, rattitude and FW manual modes

@LorenzMeier
Copy link
Member

@bresch I don't think termination is the right choice here. I would limit to 3 seconds or less and lock the system down rather than triggering termination.

Otherwise we will have parachute deployments on the ground and some of them are kinetic (explosives).

Copy link
Member

@LorenzMeier LorenzMeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be a lockdown without termination (the architecture enables that) and a shorter period to make sure we've not left the ground.

During the first few seconds after takeoff, the failure detector is allowed to
trigger motor lockdown.
This is done for safety reasons to detect tipping-over or unstable
tuning gains
@bresch bresch requested a review from LorenzMeier March 23, 2020 08:45
Copy link
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@bresch bresch merged commit 1f4b2d1 into master Mar 23, 2020
@bresch bresch deleted the pr-fd-takeoff branch March 23, 2020 12:45
@bresch bresch changed the title Flight termination: terminate if failure is detected on takeoff Flight termination: lockdown if failure is detected on takeoff Mar 26, 2020
@mrpollo mrpollo mentioned this pull request Mar 26, 2020
@hamishwillee
Copy link
Contributor

@bresch Did you make the changes needed in docs for this? i.e. as discussed in #14428 (comment)

Did this end up being "flight termination" or some other action? Still triggered by the failure detector?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants