enable WV function on land/rtl/loiter/takeoff #13740
Conversation
There was a problem hiding this comment.
Thanks for your PR, it seems to fix the bug. However, I'm wondering if there's a cleaner way to do it. How about setting _navigator->get_position_setpoint_triplet()->current.allow_weather_vane = true; in here instead? And similarly also in land.cpp and loiter.cpp.
|
|
||
| /* invalidate position setpoint by default */ | ||
| _navigator->get_position_setpoint_triplet()->current.valid = false; |
There was a problem hiding this comment.
why is this change needed?
There was a problem hiding this comment.
Because when I was in Gazebo simulation, I found that it was not running here.：https://github.com/PX4/Firmware/pull/13740/files#diff-ca6b0e7090d881629e9e3cd91610fb09L95
on_activation Is a virtual function
There was a problem hiding this comment.
I'm against this change. It's scary and I'm not sure we know all of the effects of this.
There was a problem hiding this comment.
@julianoes You are right, but can I just delete it instead of moving here?
Because it will not be run here(https://github.com/PX4/Firmware/pull/13740/files#diff-ca6b0e7090d881629e9e3cd91610fb09L95), it is invalid code
thanks review 😃
xdwgood
changed the title
There was a problem hiding this comment.
From my side this looks ok but I don't know much about VTOL so I defer the review to @sfuhrer or @RomanBapst.
To fix： #13725