FIX: Crash after ST24/16 power down PX4#13265

[ultrasystem]

reset _decode_state and _rxlen after RC data read

[julianoes]

Hi @ultrasystem, why did you close this again?

[tonirosendahl]

Hi, @julianoes and @ultrasystem, I think I was able to reproduce this on V1.10.0-beta1, running on stock Yuneec Typhoon H 480 (ST16 transmitter, SR24 receiver) with custom board definitions (based on Omnibus F4SD) and a customized bootloader. When the ST16 is powered down or the control link is disconnected otherwise, random crashy things happen, like communication timeout to QGroundcontrol with a complete system freeze, Gyro0/Accelerometer0/Magnetometer0 timeout, motor shutdown etc.

[tonirosendahl]

The st24_reset() called from RCInput.cpp line 501 as proposed in this pull request, seems to fix the crashes when the ST16 is powered off, but at least for me, when the transmitter is on, it causes constant switching between manual control lost - regained - failsafe enabled.

[tonirosendahl]

The st24_reset(); seems to fix the issue and work properly when called at line 530 of RCInput.cpp. The FC does not crash when transmitter is powered off, the failsafe mode is enabled properly, and it seems to fly OK too, at least during my short two test flights indoors.

st24_reset();
// Scan the next protocol
set_rc_scan_state(RC_SCAN_SUMD);

[julianoes]

@tonirosendahl ok, can you make a pull request for the fix that you're suggesting?

[ultrasystem]

Hi @ultrasystem, why did you close this again?

Some people don't allow me to publish this fix publicly, but fortunately, as @tonirosendahl said, st24_reset can be used to resolve this bug before the DSM state transition.

[julianoes]

Some people don't allow me to publish this fix publicly

That would be sad. It's just a bugfix right, not a proprietary super feature 😄?

[JoshG20]

Can someone check up on this pull request? it seems to have errors, but if its not too hard to fix it would be great to get this in master.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.