Position Control Refactoring Part 2 #13248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
This is part 2 of the refactoring from the monster pr #12072 and should be easy to understand and review since the diff is manageable.
Describe your solution
vehicle_local_position_setpoint
message to arrays because they most of the time are loaded into Vector3fs immediately anyways and it doesn't make sense to write x, y, z out every time. Same goes for position and velocity but the interface to flight review should be switched in one go and not message by message so I'll combine that with RC: Have all sticks scaled from -1 to 1 in the normalized representation #9331Test data / coverage
SITL tested except for the WeatherVane library but double-checked it gets the exact same data.
Additional context
Part 1 that goes before this: #13247
Part 3 that comes after this: #13262