Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position Control Refactoring Part 2 #13248

Merged
merged 3 commits into from
Oct 24, 2019
Merged

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Oct 22, 2019

Describe problem solved by this pull request
This is part 2 of the refactoring from the monster pr #12072 and should be easy to understand and review since the diff is manageable.

Describe your solution

  • Changing the acceleration and jerk in the vehicle_local_position_setpoint message to arrays because they most of the time are loaded into Vector3fs immediately anyways and it doesn't make sense to write x, y, z out every time. Same goes for position and velocity but the interface to flight review should be switched in one go and not message by message so I'll combine that with RC: Have all sticks scaled from -1 to 1 in the normalized representation #9331
  • The WeatherVane library needs just the last column of the attitude rotation matrix so it's not necessary to keep the whole attitude setpoint and pass the quaternion. I refactored it to take just that last column.
  • Since the attitude setpoint is not needed as a position control state it can be filled on the stack and published.

Test data / coverage
SITL tested except for the WeatherVane library but double-checked it gets the exact same data.

Additional context
Part 1 that goes before this: #13247
Part 3 that comes after this: #13262

@MaEtUgR MaEtUgR self-assigned this Oct 22, 2019
@MaEtUgR MaEtUgR changed the title Position control refactoring2 Position Control Refactoring Part 3 Oct 22, 2019
@MaEtUgR MaEtUgR changed the title Position Control Refactoring Part 3 Position Control Refactoring Part 2 Oct 22, 2019
@MaEtUgR MaEtUgR force-pushed the position-control-refactoring2 branch 2 times, most recently from a352077 to fa1868d Compare October 23, 2019 12:19
@MaEtUgR MaEtUgR changed the base branch from position-control-refactoring to master October 23, 2019 15:34
@MaEtUgR MaEtUgR force-pushed the position-control-refactoring2 branch from fa1868d to cb3c52f Compare October 23, 2019 15:48
Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find anything to criticize :D

@bresch
Copy link
Member

bresch commented Oct 24, 2019

@MaEtUgR Can't wait for part 3 🤓

@MaEtUgR MaEtUgR merged commit 40edd33 into master Oct 24, 2019
@MaEtUgR MaEtUgR deleted the position-control-refactoring2 branch October 24, 2019 12:59
@MaEtUgR
Copy link
Member Author

MaEtUgR commented Oct 24, 2019

@bresch Thank you! 👍
Here is part 3: #13262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants