Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mavlink receiver SET_ATTITUDE_TARGET filling for VTOLs #13140

Closed

Conversation

irsdkv
Copy link
Contributor

@irsdkv irsdkv commented Oct 9, 2019

Add MAV_TYPE_VTOL_* to thrust filling

Describe problem solved by the proposed pull request
Thrust received from SET_ATTITUDE_TARGET does not filled for VTOL airframe types.

Test data / coverage
Tested on real UAV and MAVSDK.

Describe your preferred solution
Add VTOL types to thrust filling.

 Add MAV_TYPE_VTOL_* to thrust filling
Copy link
Contributor

@jlecoeur jlecoeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a potential duplicate of #13122

Comment on lines +1400 to 1404
case MAV_TYPE_VTOL_DUOROTOR:
case MAV_TYPE_VTOL_QUADROTOR:
case MAV_TYPE_VTOL_TILTROTOR:
case MAV_TYPE_VTOL_RESERVED2:
att_sp.thrust_body[2] = -set_attitude_target.thrust;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work only in MC mode, att_sp.thrust_body[0] should be used when in fixed mode.

@irsdkv irsdkv closed this Oct 9, 2019
@irsdkv
Copy link
Contributor Author

irsdkv commented Oct 9, 2019

Close due to #13141

@irsdkv irsdkv deleted the pr-add_vtol_to_set_att_target_filling branch October 9, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants