Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mavlink: ifdef networking code #12991

Merged
merged 2 commits into from
Sep 21, 2019
Merged

Mavlink: ifdef networking code #12991

merged 2 commits into from
Sep 21, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented Sep 19, 2019

Split out of #12967.

dagar added a commit that referenced this pull request Sep 19, 2019
@dagar dagar requested a review from julianoes September 19, 2019 20:34
@dagar
Copy link
Member Author

dagar commented Sep 19, 2019

Saves a bit of flash on NuttX boards with no networking (nearly all of them).

@julianoes
Copy link
Contributor

Can't we just get #12967 in?

@dagar
Copy link
Member Author

dagar commented Sep 20, 2019

This goes a bit further (consolidating defines) and we don't have consensus yet in #12967.

Copy link
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks correct.

@dagar dagar merged commit fe4f6c1 into master Sep 21, 2019
@dagar dagar deleted the pr-mavlink_ifdefs branch September 21, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants