Remove unsafe access to .data() and _data in Matrix #12964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
dagar
reviewed
Sep 16, 2019
jkflying
force-pushed
the
remove-unsafe-matrix-access
branch
from
de1f36d to
430e3c0
Compare
|
|
4 tasks
|
We have to update the ecl again after it get merged. |
MaEtUgR
reviewed
Sep 18, 2019
MaEtUgR
force-pushed
the
remove-unsafe-matrix-access
branch
from
a9ce872 to
d64a9cc
Compare
jkflying
force-pushed
the
remove-unsafe-matrix-access
branch
from
d64a9cc to
4a625c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes access to the unsafe .data() and _data in Matrix.
Linked PRs which should be merged first:
PX4/PX4-Matrix#90MergedPX4/PX4-ECL#641Merged