v5x adds ADC3 Support #12643
Merged
v5x adds ADC3 Support #12643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug introduced in 320d2e adding platform layer.
fmu-v5x:hrt needs to be running for ADC time out
Fixes bug introduced in 320d2e adding platform layer.
dagar
approved these changes
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dagar - first commit fixes bug introduced in 320d2e adding platform layer. (The ordering in HW files matters) and should come into master for fmuv5.
Second added the support for ADC 3 to be used for HW versioning.
Third is the usage.
This has been tested on V3, V5 (Mini, 5+), V5X
If we add the ADC to the manifest in the future then the singleton code can come out. But all boards HW will need to be updated to call the ADC but only init AFTER the hrt init.
The way it is it gets done once when the ADC is needed. If Rev 0 / Ver 0 is detected the the code does not init the ADC!