Fix vehicle flight time #12448
Merged
Fix vehicle flight time #12448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_param_total_flight_time_low.get()` is an int32_t and gets sign-extended if cast directly to uint64_t. To avoid that we first cast to uint32_t.
LorenzMeier
approved these changes
Jul 9, 2019
|
So flight time will be bogus for anyone that flew master since June 5th? faa3c3d#diff-1fd2cab203a1ba1c362f2dd76a74542f |
@bkueng is obviously right in this PR. @dagar, I did check the total flight time values in the logs I posted in that PR and they appear correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_param_total_flight_time_low.get()is an int32_t and gets sign-extended if cast directly to uint64_t. To avoid that we first cast to uint32_t.