navigator move to new uORB::Subscription #12162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
force-pushed
the
pr-navigator_subscription
branch
from
c200fd0 to
4758d33
Compare
dagar
force-pushed
the
pr-navigator_subscription
branch
from
4758d33 to
aa8bbdb
Compare
julianoes
reviewed
Jun 4, 2019
julianoes
approved these changes
Jun 4, 2019
|
Looks like the testing results ended up over here. #12123 (comment) |
ndepal
reviewed
Jun 6, 2019
| @@ -72,11 +72,6 @@ PrecLand::PrecLand(Navigator *navigator) : | |||
| void | |||
| PrecLand::on_activation() | |||
| { | |||
| // We need to subscribe here and not in the constructor because constructor is called before the navigator task is spawned | |||
There was a problem hiding this comment.
Where/when does the subscription happen now? Is the problem described in the comment no longer an issue?
There was a problem hiding this comment.
It's not longer an issue with the new uORB::Subscription that subscribes to orb internally (bypassing file descriptors).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.