Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init.d-posix: raise timeouts for fast SITL #12010

Merged
merged 2 commits into from
May 14, 2019
Merged

Conversation

julianoes
Copy link
Contributor

When simulating with lockstep we can raise the speed by setting the env variable PX4_SIM_SPEED_FACTOR. Some inputs like RC, MAVLink heartbeats from a ground station, or offboard controls via MAVLink are still at the normal speed which leads to timeouts getting detected in PX4.

To work around this issue we can automatically multiply the timeout parameters by the speed factor.

@julianoes julianoes requested review from dagar and bkueng May 13, 2019 12:12
When simulating with lockstep we can raise the speed by setting the env
variable `PX4_SIM_SPEED_FACTOR`. Some inputs like RC, MAVLink heartbeats
from a ground station, or offboard controls via MAVLink are still at the
normal speed which leads to timeouts getting detected in PX4.

To work around this issue we can automatically multiply the timeout
parameters by the speed factor.
@julianoes julianoes force-pushed the pr-adapt-timeouts branch from 9fbc1e5 to 40cdedd Compare May 13, 2019 12:41
@dagar
Copy link
Member

dagar commented May 13, 2019

ShellCheck failure in CI (continuous-integration/jenkins/pr-head). http://ci.px4.io:8080/blue/organizations/jenkins/PX4%2FFirmware/detail/PR-12010/2/pipeline

image

@julianoes
Copy link
Contributor Author

@dagar thanks, I'll try to improve that.

Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather have this using the real systemtime where needed, but I'm ok with this for now.

@julianoes julianoes merged commit 01fdd00 into master May 14, 2019
@julianoes julianoes deleted the pr-adapt-timeouts branch May 14, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants