Fix mission change speed #11811
Closed
Fix mission change speed #11811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue where the DO_CHANGE_SPEED command was ignored and the drone always travelled at the MPC_XY_CRUISE velocity.
|
Thanks, this doesn't fix it. It does work for speeds set slower than cruise velocity but for speeds faster than cruise we're limited to cruise. |
|
@julianoes Hmm, then I don't understand how your fix worked before. |
|
@julianoes Should be good now but I'm not sure of the side effects. We need to do a non-regression test before merging that. |
|
Still the same problem. If you want to reproduce the tests, this is the Dronecode SDK command: |
Merged
|
Replaced by #11836. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11764
@julianoes Please check if it fixes the issue.