Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misprints in parameters naming and description #11680

Closed
wants to merge 2 commits into from
Closed

Misprints in parameters naming and description #11680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f93b66
Misprints in parameters naming and description
EgoPingvina Mar 19, 2019
4b9f376
Update fw_att_control_params.c
EgoPingvina Mar 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/modules/fw_att_control/fw_att_control_params.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ PARAM_DEFINE_FLOAT(FW_W_RMAX, 30.0f);
* Roll rate feed forward
*
* Direct feed forward from rate setpoint to control surface output. Use this
* to obtain a tigher response of the controller without introducing
* to obtain a tighter response of the controller without introducing
* noise amplification.
*
* @unit %/rad/s
Expand Down Expand Up @@ -583,7 +583,7 @@ PARAM_DEFINE_FLOAT(FW_MAN_Y_SC, 1.0f);
/**
* Whether to scale throttle by battery power level
*
* This compensates for voltage drop of the battery over time by attempting to
* This compensates for a voltage drop of the battery over time by attempting to
* normalize performance across the operating range of the battery. The fixed wing
* should constantly behave as if it was fully charged with reduced max thrust
* at lower battery percentages. i.e. if cruise speed is at 0.5 throttle at 100% battery,
Expand Down
2 changes: 1 addition & 1 deletion src/modules/vtol_att_control/standard.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ Standard::Standard(VtolAttitudeControl *attc) :
_mc_yaw_weight = 1.0f;
_mc_throttle_weight = 1.0f;

_params_handles_standard.pusher_ramp_dt = param_find("VT_PSHER_RMP_DT");
_params_handles_standard.pusher_ramp_dt = param_find("VT_PUSHER_RMP_DT");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RomanBapst @sanderux You OK with the param name changes here? AFAIK parameters can be max 16 chars, and this is IMO better.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"VT_PUSHER_RMP_DT" - there are exactly 16 characters

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @EgoPingvina - I checked and I am happy with that, but I'm not maintainer of this code - hence query to @RomanBapst

_params_handles_standard.back_trans_ramp = param_find("VT_B_TRANS_RAMP");
_params_handles_standard.down_pitch_max = param_find("VT_DWN_PITCH_MAX");
_params_handles_standard.forward_thrust_scale = param_find("VT_FWD_THRUST_SC");
Expand Down
2 changes: 1 addition & 1 deletion src/modules/vtol_att_control/standard_params.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,4 +111,4 @@ PARAM_DEFINE_FLOAT(VT_B_REV_DEL, 0.0f);
* @decimal 2
* @group VTOL Attitude Control
*/
PARAM_DEFINE_FLOAT(VT_PSHER_RMP_DT, 3.0f);
PARAM_DEFINE_FLOAT(VT_PUSHER_RMP_DT, 3.0f);