Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mathlib Limits don't bother using references #11411

Merged
merged 1 commit into from
Feb 8, 2019
Merged

mathlib Limits don't bother using references #11411

merged 1 commit into from
Feb 8, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented Feb 8, 2019 •
edited by AuterionWrikeBot
Loading

@dagar dagar added this to the Release v1.9.0 milestone Feb 8, 2019
@dagar dagar mentioned this pull request Feb 8, 2019
Closed
@dagar dagar force-pushed the pr-addr_packed_warn branch 3 times, most recently from 3c987a3 to 2c40cbc Compare February 8, 2019 04:43
@dagar dagar force-pushed the pr-addr_packed_warn branch from be35931 to 3d922d7 Compare February 8, 2019 13:13
@dagar dagar changed the title WIP: mathlib Limits don't bother using references mathlib Limits don't bother using references Feb 8, 2019
@dagar dagar requested a review from davids5 February 8, 2019 13:31
davids5
davids5 previously approved these changes Feb 8, 2019
View reviewed changes
@dagar dagar force-pushed the pr-addr_packed_warn branch 2 times, most recently from 0d546df to 929e0f0 Compare February 8, 2019 15:29
@dagar
Copy link
Member Author

dagar commented Feb 8, 2019 •
edited
Loading

image

Update: pymavlink PR ArduPilot/pymavlink#267

@dagar dagar force-pushed the pr-addr_packed_warn branch 2 times, most recently from 24e4d6b to 274d043 Compare February 8, 2019 15:53
davids5
davids5 previously approved these changes Feb 8, 2019
View reviewed changes
@dagar
mathlib Limits don't use references
5c5409f 
 - cleanup Limits.hpp
 - add -Waddress-of-packed-member where available
 - fixes #11408
@dagar dagar force-pushed the pr-addr_packed_warn branch from 274d043 to 5c5409f Compare February 8, 2019 16:59
@dagar dagar merged commit 2217faf into master Feb 8, 2019
@dagar dagar deleted the pr-addr_packed_warn branch February 8, 2019 19:10
@weekly-digest weekly-digest bot mentioned this pull request Feb 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkueng bkueng bkueng left review comments

@davids5 davids5 davids5 left review comments

Assignees
No one assigned
Labels
bug priority-critical
Projects
None yet
Milestone
Release v1.9.0
Development

Successfully merging this pull request may close these issues.

Issue with Master_vehicle crash
3 participants
@dagar @bkueng @davids5