Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[READY FOR test] Add f7 bl update #11394

Merged
merged 3 commits into from
Jun 16, 2019
Merged

[READY FOR test] Add f7 bl update #11394

merged 3 commits into from
Jun 16, 2019

Conversation

davids5
Copy link
Member

@davids5 davids5 commented Feb 6, 2019

@DanielePettenuzzo - please test

@davids5
Copy link
Member Author

davids5 commented Feb 6, 2019

We need to see if the Nuttx Driver needs the dsb instructions added as in https://github.com/PX4/Bootloader/blob/master/main_f7.c#L570

@DanielePettenuzzo
Copy link
Contributor

@davids5 I tried it a couple times with two different bootloader binaries and it seems to work on fmu-v5 (pixhawk 4).

@weekly-digest weekly-digest bot mentioned this pull request Feb 10, 2019
Closed
@davids5 davids5 requested a review from dagar February 13, 2019 13:33
@davids5 davids5 changed the title [WIP] add f7 bl update [READY FOR test] Add f7 bl update Feb 13, 2019
@davids5
Copy link
Member Author

davids5 commented Feb 13, 2019

@DanielePettenuzzo - Are you comfortable the the level of testing to bring this in?

@davids5 davids5 closed this Feb 13, 2019
@davids5 davids5 reopened this Feb 13, 2019
@davids5 davids5 mentioned this pull request Feb 13, 2019
Open
@dagar dagar removed the devcall label Feb 13, 2019
@davids5 davids5 force-pushed the master_add_f7_bl_update branch from db86c3f to 823212a Compare February 13, 2019 16:07
@DanielePettenuzzo
Copy link
Contributor

@davids5 I tried this on 4 new pixhawk 4 and it was always successful

@weekly-digest weekly-digest bot mentioned this pull request Feb 24, 2019
Closed
@dagar
Copy link
Member

dagar commented Mar 6, 2019

Rebase and merge?

@davids5 davids5 force-pushed the master_add_f7_bl_update branch from 823212a to a87afad Compare March 7, 2019 13:26
@davids5
Copy link
Member Author

davids5 commented Mar 7, 2019

@dagar rebased on master

@davids5
Copy link
Member Author

davids5 commented Mar 7, 2019

@dagar I am waiting on some definitive feedback before merging.

@dagar dagar requested a review from DanielePettenuzzo March 7, 2019 20:20
@weekly-digest weekly-digest bot mentioned this pull request Mar 10, 2019
Closed
@dagar dagar merged commit f96c47a into master Jun 16, 2019
@dagar dagar deleted the master_add_f7_bl_update branch June 16, 2019 01:46
@weekly-digest weekly-digest bot mentioned this pull request Jun 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagar dagar dagar approved these changes

@DanielePettenuzzo DanielePettenuzzo Awaiting requested review from DanielePettenuzzo

Assignees
No one assigned
Labels
Admin: Enhancement (improvement) 💡
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davids5 @DanielePettenuzzo @dagar