Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

px4_fmu-v5 board spi cleanup #11370

Merged
merged 2 commits into from
Feb 9, 2019
Merged

px4_fmu-v5 board spi cleanup #11370

merged 2 commits into from
Feb 9, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented Feb 4, 2019 •
edited by AuterionWrikeBot
Loading

  • px4_fmu-v5 spi handler convert to c++ and use range based for loops instead of first/last defines
  • remove px4 headers
    • use syslog instead of PX4_ERR, PX4_WARN, etc
  • remove dummy BMA, BMI SPIDEVs
  • remove stm32_spi_bus_initialize
    • handled by the actual drivers
  • delete unused static variables

@dagar dagar requested a review from davids5 February 4, 2019 15:06
@dagar dagar force-pushed the pr-fmu-v5_bsp_spi branch from 6c1cb3f to dc1cc71 Compare February 4, 2019 15:20
@dagar dagar mentioned this pull request Feb 4, 2019
Closed
@dagar
Copy link
Member Author

dagar commented Feb 4, 2019 •
edited
Loading

Questions

  • PX4_SPIDEV_SPI4_CS2
    • Not used, remove? Left in place.
  • PX4_SPIDEV_AUX_MEM
    • supposed to be on SPI1? Moved to SPI1.

@dagar dagar added Board: Pixhawk fmu-v5 FMU-v5 including pixhawk 4, pixhack v5, etc NuttX (OS) labels Feb 4, 2019
davids5
davids5 reviewed Feb 4, 2019
View reviewed changes
Copy link
Member

@davids5 davids5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See in line comments

@davids5
Copy link
Member

davids5 commented Feb 4, 2019

@dagar your call. I prefer the Board config matches the pinout. Usage may vary.

Questions

  • PX4_SPIDEV_SPI4_CS2
  • Not used, remove?

https://docs.google.com/spreadsheets/d/1-n0__BYDedQrc_2NHqBenG1DNepAgnHpSGglke-QQwY/edit#gid=912976165

91 PF 11 R6 PF11 SPI4_CS2 Digital OUPUT: Active Low SPI Chip Select Not used if MS56xx is used on SPI Bus 4                                          

  • PX4_SPIDEV_AUX_MEM

    • supposed to be on SPI1?

Yes. On HB v5 is is on SPI1

118 PH 5 J4 PH5 SPIAUX_CS_MEM Digital OUPUT: Active Low SPI Chip Select for an EEPROM collocated on Sensor board, used for factory set temperature calibration data                                          

@dagar dagar force-pushed the pr-fmu-v5_bsp_spi branch 4 times, most recently from e309cdf to e62c77d Compare February 4, 2019 21:58
@dagar
Copy link
Member Author

dagar commented Feb 4, 2019

Bench tested on a pixhawk 4.

@dagar dagar requested a review from a team February 5, 2019 17:03
@dagar
Copy link
Member Author

dagar commented Feb 5, 2019

@PX4/testflights could you give this a quick test on any fmu-v5 unit (Pixhawk 4, 4 mini)? Thanks!

@dannyfpv
Copy link

dannyfpv commented Feb 6, 2019 •
edited by Tony3dr
Loading

Tested on Pixhawk 4 v5, Good Flight.
https://review.px4.io/plot_app?log=1a037a18-a0e3-4f1c-9365-b9716c7b15a7

Pixhawk 4 Mini v5, Good Flight.
https://review.px4.io/plot_app?log=7ebec132-efe6-49ee-91c9-336cfe1ebde9

@dagar dagar mentioned this pull request Feb 7, 2019
Closed
@dagar dagar requested a review from simonegu February 7, 2019 15:33
@dagar dagar force-pushed the pr-fmu-v5_bsp_spi branch from e62c77d to 36faf67 Compare February 7, 2019 16:12
@dagar
Copy link
Member Author

dagar commented Feb 7, 2019

@simonegu I added a commit to remove PX4_FMUV5_RC00.

davids5
davids5 previously requested changes Feb 7, 2019
View reviewed changes
@dagar dagar force-pushed the pr-fmu-v5_bsp_spi branch from 36faf67 to 2fa9dee Compare February 7, 2019 18:33
@dagar dagar dismissed davids5’s stale review February 7, 2019 18:33

extra define removed

simonegu
simonegu approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@simonegu simonegu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one comment on the name change.

@dagar dagar merged commit adad624 into PX4:master Feb 9, 2019
@dagar dagar deleted the pr-fmu-v5_bsp_spi branch February 9, 2019 01:52
@weekly-digest weekly-digest bot mentioned this pull request Feb 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davids5 davids5 davids5 approved these changes

@simonegu simonegu simonegu approved these changes

Assignees
No one assigned
Labels
Board: Pixhawk fmu-v5 FMU-v5 including pixhawk 4, pixhack v5, etc NuttX (OS)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dagar @davids5 @dannyfpv @simonegu