Indicate version in which SYS_COMPANION deprecated #11327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkueng
reviewed
Jan 29, 2019
src/lib/systemlib/system_params.c
Outdated
| @@ -111,8 +111,8 @@ PARAM_DEFINE_INT32(SYS_MC_EST_GROUP, 2); | |||
| /** | |||
| * TELEM2 as companion computer link (deprecated) | |||
| * | |||
| * This parameter is deprecated. Do not change it, use the more generic serial | |||
| * configuration parameters instead. | |||
| * This parameter is deprecated (from PX4 v1.8.1). Use the generic serial | |||
There was a problem hiding this comment.
v1.8.1 does not include the new ones yet, only the next release will (v1.9).
There was a problem hiding this comment.
OK. From a docs point of view then we could either ignore this OR modify slightly to:
* This parameter is deprecated and will be removed in 1.9.0. Use the generic serial
* configuration parameters instead (e.g. MAV_0_CONFIG, MAV_0_MODE, etc.).
There was a problem hiding this comment.
Right, we can update to will be removed after 1.9.0 (in would mean to me that it's already removed with 1.9.0).
There was a problem hiding this comment.
Done (and yes, you're right about the use of "in vs. after"). Squash and merge at will!
dagar
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful to know what version the parameter was deprecated and more clearly identify the parameters to use instead - see PX4/PX4-Devguide#724
@bkueng Do we need a deprecated / use instead flag in the markup?