[WIP] px4io driver always build io firmware #11042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @dagar. What's the ETA? |
julianoes
requested changes
Jul 15, 2019
| DEPENDS px4io_firmware | ||
| COMMAND ${CMAKE_OBJCOPY} -O binary ${fw_io_exe} ${config_io_board}.bin | ||
| COMMAND ${CMAKE_COMMAND} -E copy_if_different ${config_io_board}.bin ${PX4_BINARY_DIR}/romfs_extras/${config_io_board}.bin | ||
| DEPENDS px4io_firmware px4_io-v2_default.elf |
There was a problem hiding this comment.
I remember add_custom_command can't depend on a file but only on targets, so you need to add a target in-between, e.g.:
add_custom_target(
px4_io_v2_default_elf_target
DEPENDS px4_io-v2_default.elf
)
jlecoeur
added a commit
that referenced
this pull request
Aug 25, 2019
This fixes incremental build of the px4io firmware on targets that use the px4io driver. fixes #11042
bozkurthan
pushed a commit
to bozkurthan/Firmware
that referenced
this pull request
Sep 4, 2019
This fixes incremental build of the px4io firmware on targets that use the px4io driver. fixes PX4#11042
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the cmake configure and build steps are split we should be able to BUILD_ALWAYS and achieve what we want.
TODO:
https://cmake.org/cmake/help/latest/module/ExternalProject.html
fixes #11036