board specific driver and module organization #10964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
force-pushed
the
pr-reorg
branch
3 times, most recently
from
b9df0f3 to
5e2a09f
Compare
|
Not building yet |
dagar
force-pushed
the
pr-reorg
branch
4 times, most recently
from
aa1571c to
3a2a234
Compare
|
Good to go. |
bkueng
approved these changes
Dec 3, 2018
| # add_subdirectory(src/drivers/boards EXCLUDE_FROM_ALL) | ||
| # | ||
| # so include bbblue board specific code here: | ||
| ../src/init.c |
There was a problem hiding this comment.
Probably not, but I didn't want to get too far into it without this board even compiling in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new board directories we now have a place where board specific drivers and modules can reside.
These components are automatically included via standard cmake mechanisms in the board itself. It further simplifies the board configuration as well as the core Firmware source tree.