-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mTECS #1037
mTECS #1037
Conversation
Conflicts: src/modules/fw_pos_control_l1/fw_pos_control_l1_main.cpp
I'm interested in helping to test this branch. A few questions:
|
This here is a merge of ongoing mtecs, navigator and estimator work, highly WIP https://github.com/PX4/Firmware/tree/navigator_rewrite_estimator
Currently only a diagram and the param descriptions (in the code), more to come of course |
@thomasgubler When can we expect some more mTECS docs? I think you have now a whole bunch of developers asking for them and it really would benefit the further development to make a grey box out of the current black box. We're not quite far from merging it to master and so documentation should be a primary concern now. |
As soon as most technical issues from the weekend testing are resolved... |
Meanwhile I added more docs http://pixhawk.org/dev/control/mtecs |
float windspeed_north; /**< Wind component in north / X direction */ | ||
float windspeed_east; /**< Wind component in east / Y direction */ | ||
float covariance_north; /**< Uncertainty - set to zero (no uncertainty) if not estimated */ | ||
float covariance_east; /**< Uncertainty - set to zero (no uncertainty) if not estimated */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two recommendations here:
- Publish the whole 2-by-2 covariance matrix for windspeed
- Might as well capture and use all the data that we have. Easier to put it in now.
- Set to negative number for unknown or not estimated
- While unlikely, zero variance is a possible value for variance calculation. Negative variance is not possible. Let's set a good convention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This goes into the same directions as my comments here #1036
--> Let's extend the interface when we need it
@thomasgubler Compared to the state of master this is by now in a much better shape - given that better docs than for master exist, how about getting this in? |
I'm not having very good performance in HIL using X-Plane 10 using default On Thu, Jun 26, 2014 at 8:50 AM, Lorenz Meier notifications@github.com
|
@achambers16 The params for the HilStar are not tuned at all. You will want to tune them using the guide Thomas wrote: |
The only thing preventing this from merging right now is the fmuv1 flash size issue. |
…est and support one.
@thomasgubler Please see #1084 and #1085 for flash improvements. I propose to merge both and to merge this to master. |
Remove old TECS implementation - we can really only decently flight-test...
@LorenzMeier do you want to keep the tests removed for fmu1? They still don't fit... |
@thomasgubler Given that your comment is addressed, merging this now. This is a really great contribution and a lot of work, thanks! |
This is Thomas' total energy control system. Heavily tested in the last days, its now a good time to start ironing out the last kinks and establishing trust logs. Should also be made the default on master.
@thomasgubler @sjwilks @AndreasAntener Please provide additional comments here. Less branches will mean less confusion in the next weeks testing 8).