Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mTECS #1037

Merged
merged 104 commits into from
Jun 29, 2014
Merged

mTECS #1037

merged 104 commits into from
Jun 29, 2014

Conversation

LorenzMeier
Copy link
Member

This is Thomas' total energy control system. Heavily tested in the last days, its now a good time to start ironing out the last kinks and establishing trust logs. Should also be made the default on master.

@thomasgubler @sjwilks @AndreasAntener Please provide additional comments here. Less branches will mean less confusion in the next weeks testing 8).

thomasgubler and others added 30 commits March 10, 2014 23:37
Conflicts:
	src/modules/fw_pos_control_l1/fw_pos_control_l1_main.cpp
@achambers16
Copy link
Contributor

I'm interested in helping to test this branch. A few questions:

  • Should I wait for Navigator Rewrite #1046 to be merged in?
  • Is there any documentation on mTECS? How about mTECS versus the current TECS? Besides finding bugs, what should I be looking for in terms of performance or behavior?

@thomasgubler
Copy link
Contributor

Should I wait for #1046 to be merged in?

This here is a merge of ongoing mtecs, navigator and estimator work, highly WIP https://github.com/PX4/Firmware/tree/navigator_rewrite_estimator
You can test mtecs separately though

is there any documentation on mTECS?

Currently only a diagram and the param descriptions (in the code), more to come of course
http://pixhawk.org/dev/control/mtecs

@LorenzMeier
Copy link
Member Author

@thomasgubler When can we expect some more mTECS docs? I think you have now a whole bunch of developers asking for them and it really would benefit the further development to make a grey box out of the current black box. We're not quite far from merging it to master and so documentation should be a primary concern now.

@thomasgubler
Copy link
Contributor

As soon as most technical issues from the weekend testing are resolved...

@thomasgubler
Copy link
Contributor

Meanwhile I added more docs http://pixhawk.org/dev/control/mtecs
Also airspeed is now filtered (additionally) for use in the mtecs calculations.

float windspeed_north; /**< Wind component in north / X direction */
float windspeed_east; /**< Wind component in east / Y direction */
float covariance_north; /**< Uncertainty - set to zero (no uncertainty) if not estimated */
float covariance_east; /**< Uncertainty - set to zero (no uncertainty) if not estimated */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two recommendations here:

  1. Publish the whole 2-by-2 covariance matrix for windspeed
  • Might as well capture and use all the data that we have. Easier to put it in now.
  1. Set to negative number for unknown or not estimated
  • While unlikely, zero variance is a possible value for variance calculation. Negative variance is not possible. Let's set a good convention.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes into the same directions as my comments here #1036
--> Let's extend the interface when we need it

@LorenzMeier
Copy link
Member Author

@thomasgubler Compared to the state of master this is by now in a much better shape - given that better docs than for master exist, how about getting this in?

@achambers16
Copy link
Contributor

I'm not having very good performance in HIL using X-Plane 10 using default
parameters. Maybe I need to tune it? I'm using the "HilStar, X-Plane"
airframe configuration.
I'm seeing quite a bit of oscillation in airspeed and altitude. And poor
airspeed control to the FW_AIRSPD_TRIM setting.
Disabling mtecs via the parameter results in better flight performance.
Any ideas?

On Thu, Jun 26, 2014 at 8:50 AM, Lorenz Meier notifications@github.com
wrote:

@thomasgubler https://github.com/thomasgubler Compared to the state of
master this is by now in a much better shape - given that better docs than
for master exist, how about getting this in?


Reply to this email directly or view it on GitHub
#1037 (comment).

@LorenzMeier
Copy link
Member Author

@achambers16 The params for the HilStar are not tuned at all. You will want to tune them using the guide Thomas wrote:
http://pixhawk.org/dev/control/mtecs

@thomasgubler
Copy link
Contributor

The only thing preventing this from merging right now is the fmuv1 flash size issue.

@LorenzMeier
Copy link
Member Author

@thomasgubler Please see #1084 and #1085 for flash improvements. I propose to merge both and to merge this to master.

Remove old TECS implementation - we can really only decently flight-test...
@thomasgubler
Copy link
Contributor

@LorenzMeier do you want to keep the tests removed for fmu1? They still don't fit...

@LorenzMeier
Copy link
Member Author

@thomasgubler Given that your comment is addressed, merging this now. This is a really great contribution and a lot of work, thanks!

LorenzMeier added a commit that referenced this pull request Jun 29, 2014
@LorenzMeier LorenzMeier merged commit e5bd00e into master Jun 29, 2014
@thomasgubler thomasgubler deleted the mtecs branch June 29, 2014 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants