Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reboot with forcing to bootloader gets swallowed by MAVLink #5501

Closed
AndreasAntener opened this issue Sep 16, 2016 · 3 comments
Closed

Reboot with forcing to bootloader gets swallowed by MAVLink #5501

AndreasAntener opened this issue Sep 16, 2016 · 3 comments
Labels
bug

Comments

@AndreasAntener
Copy link
Contributor

@LorenzMeier why are we using MAV_CMD_PREFLIGHT_REBOOT_SHUTDOWN with param1 == 3 as link shutdown? https://github.com/PX4/Firmware/blob/7d7e40f59473ed538c61f8b76020ca505ee52487/src/modules/mavlink/mavlink_receiver.cpp#L353

According to the specs that should do an FC reboot with forcing it to bootloader. Which is implemented but never happens because of the above logic.

Funnily this could have been the same issue: #5473 (although normal boot was ok for him I guess)
@LorenzMeier
Copy link
Member

This is indeed a case where we had a custom use and then the spec got extended.

LorenzMeier added a commit that referenced this issue Sep 16, 2016
@LorenzMeier
Fix issue #5501. Link termination now requires param 2 = 10
d98bbd9
@LorenzMeier
Copy link
Member

Closed in d98bbd9.

@AndreasAntener
Copy link
Contributor Author

Thanks!

@dagar dagar mentioned this issue Sep 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LorenzMeier @AndreasAntener