Skip to content

Commit

Permalink
Update some comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
gregory-nutt committed Aug 3, 2018
1 parent 9b7e5ed commit 679d287
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
6 changes: 6 additions & 0 deletions arch/arm/src/armv7-m/gnu/up_exception.S
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,12 @@ exception_common:
#else
/* Set the BASEPRI register so that further normal interrupts will be
* masked. Nested, high priority may still occur, however.
*
* REVISIT: I think this is un-necessary: "When the processor is
* executing an exception handler, an exception can preempt the exception
* handler if its priority is higher than the priority of the exception
* being handled. See Interrupt priority grouping for more information
* about preemption by an interrupt."
*/

mov r2, #NVIC_SYSH_DISABLE_PRIORITY
Expand Down
7 changes: 7 additions & 0 deletions arch/arm/src/armv7-m/gnu/up_lazyexception.S
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ exception_common:

mov r2, sp /* R2=Copy of the main/process stack pointer */
add r2, #HW_XCPT_SIZE /* R2=MSP/PSP before the interrupt was taken */

#ifdef CONFIG_ARMV7M_USEBASEPRI
mrs r3, basepri /* R3=Current BASEPRI setting */
#else
Expand Down Expand Up @@ -197,6 +198,12 @@ exception_common:
#else
/* Set the BASEPRI register so that further normal interrupts will be
* masked. Nested, high priority may still occur, however.
*
* REVISIT: I think this is un-necessary: "When the processor is
* executing an exception handler, an exception can preempt the exception
* handler if its priority is higher than the priority of the exception
* being handled. See Interrupt priority grouping for more information
* about preemption by an interrupt."
*/

mov r2, #NVIC_SYSH_DISABLE_PRIORITY
Expand Down

0 comments on commit 679d287

Please sign in to comment.