Skip to content

Commit

Permalink
mc_acro_params: beginner/tuning friendly defaults
Browse files Browse the repository at this point in the history
high rates and (super) expo are necessary for
- acrobatic flying
- fpv
- racing
but they are not useful for:
- a typical vehicle's rate control tuning
- beginners

The defaults that I set in #8036 were put with the assumption Acro mode
is mainly used on racing drones for acrobatic manouvers but instead
users including me use it most of the time to tune any drone.
When tuning the rates are lowered and expo disabled.

My suggested strategy is to make the beginner friendly rates without
expo which are good for tuning the default and document more clearly
how this can be raised for acrobatic flying in documentation and later
on hopefully also directly in the ground station UI
on an Acro mode specific page.
  • Loading branch information
MaEtUgR committed Sep 19, 2023
1 parent 1387c9e commit 58d7bf9
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions src/modules/mc_rate_control/mc_acro_params.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
* @increment 5
* @group Multicopter Acro Mode
*/
PARAM_DEFINE_FLOAT(MC_ACRO_R_MAX, 720.0f);
PARAM_DEFINE_FLOAT(MC_ACRO_R_MAX, 100.f);

/**
* Acro mode maximum pitch rate
Expand All @@ -63,7 +63,7 @@ PARAM_DEFINE_FLOAT(MC_ACRO_R_MAX, 720.0f);
* @increment 5
* @group Multicopter Acro Mode
*/
PARAM_DEFINE_FLOAT(MC_ACRO_P_MAX, 720.0f);
PARAM_DEFINE_FLOAT(MC_ACRO_P_MAX, 100.f);

/**
* Acro mode maximum yaw rate
Expand All @@ -77,7 +77,7 @@ PARAM_DEFINE_FLOAT(MC_ACRO_P_MAX, 720.0f);
* @increment 5
* @group Multicopter Acro Mode
*/
PARAM_DEFINE_FLOAT(MC_ACRO_Y_MAX, 540.0f);
PARAM_DEFINE_FLOAT(MC_ACRO_Y_MAX, 100.f);

/**
* Acro mode roll, pitch expo factor
Expand All @@ -92,7 +92,7 @@ PARAM_DEFINE_FLOAT(MC_ACRO_Y_MAX, 540.0f);
* @decimal 2
* @group Multicopter Acro Mode
*/
PARAM_DEFINE_FLOAT(MC_ACRO_EXPO, 0.69f);
PARAM_DEFINE_FLOAT(MC_ACRO_EXPO, 0.f);

/**
* Acro mode yaw expo factor
Expand All @@ -107,7 +107,7 @@ PARAM_DEFINE_FLOAT(MC_ACRO_EXPO, 0.69f);
* @decimal 2
* @group Multicopter Acro Mode
*/
PARAM_DEFINE_FLOAT(MC_ACRO_EXPO_Y, 0.69f);
PARAM_DEFINE_FLOAT(MC_ACRO_EXPO_Y, 0.f);

/**
* Acro mode roll, pitch super expo factor
Expand All @@ -123,7 +123,7 @@ PARAM_DEFINE_FLOAT(MC_ACRO_EXPO_Y, 0.69f);
* @decimal 2
* @group Multicopter Acro Mode
*/
PARAM_DEFINE_FLOAT(MC_ACRO_SUPEXPO, 0.7f);
PARAM_DEFINE_FLOAT(MC_ACRO_SUPEXPO, 0.f);

/**
* Acro mode yaw super expo factor
Expand All @@ -139,4 +139,4 @@ PARAM_DEFINE_FLOAT(MC_ACRO_SUPEXPO, 0.7f);
* @decimal 2
* @group Multicopter Acro Mode
*/
PARAM_DEFINE_FLOAT(MC_ACRO_SUPEXPOY, 0.7f);
PARAM_DEFINE_FLOAT(MC_ACRO_SUPEXPOY, 0.f);

0 comments on commit 58d7bf9

Please sign in to comment.