Skip to content

Commit

Permalink
Revert "drivers/input/ft5x06.c: Back out part of last PR. I think tha…
Browse files Browse the repository at this point in the history
…t is correct to detach the interrupt handler when the drivers is unlinked."

No... I was misled.  The shutdown function is usually called when the
driver is unlinked.  But not in this case.  In this case, it is simply
called when the last reference is closed.  And no, you don't want to
detach the interrupt handler in that case.  My bad.

This reverts commit b79e6b9.
  • Loading branch information
gregory-nutt committed Aug 1, 2018
1 parent b79e6b9 commit 1d70e7f
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions drivers/input/ft5x06.c
Original file line number Diff line number Diff line change
Expand Up @@ -780,13 +780,6 @@ static void ft5x06_shutdown(FAR struct ft5x06_dev_s *priv)

config->clear(config);
config->enable(config, false);

/* Detach the interrupt handler (otherwise, the attach may failed if the
* driver is re-registered, depending upon how the lower-half is
* implemented.
*/

(void)config->attach(config, NULL, NULL);
#endif
}

Expand Down

0 comments on commit 1d70e7f

Please sign in to comment.