Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mavlink receiver fix PREFLIGHT_REBOOT_SHUTDOWN #8008

Merged
merged 1 commit into from
Sep 25, 2017
Merged

mavlink receiver fix PREFLIGHT_REBOOT_SHUTDOWN #8008

merged 1 commit into from
Sep 25, 2017

Conversation

dagar
Copy link
Member

@dagar dagar commented Sep 24, 2017 •
edited
Loading

Removing inconsistencies between COMMAND_LONG and COMMAND_INT (#8002) broke px_uploader.py reboot.

MAV_CMD_PREFLIGHT_REBOOT_SHUTDOWN with param 1 set to 10 is used for link shutdown, although it isn't documented in the mavlink spec.

@LorenzMeier where is link shutdown used? Do we need to keep it?

Previous issue - #5501
@AndreasAntener @jgoppert FYI

@dagar dagar requested a review from LorenzMeier September 24, 2017 17:24
@dagar
Copy link
Member Author

dagar commented Sep 24, 2017

Previously this slipped through because MAV_CMD_PREFLIGHT_REBOOT_SHUTDOWN link shutdown was only implemented for COMMAND_INT.

@dagar dagar requested a review from bkueng September 25, 2017 14:31
bkueng
bkueng approved these changes Sep 25, 2017
View reviewed changes
Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with removing the link shutdown, since it's undocumented. But if someone actually uses this already, it will break the setup.

@dagar
Copy link
Member Author

dagar commented Sep 25, 2017

I'll merge this right now to fix REBOOT.
If necessary I'll readd link shutdown, but let's get it in the spec.

@dagar dagar merged commit 420df9d into PX4:master Sep 25, 2017
@dagar dagar deleted the pr-reboot_fix branch September 25, 2017 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkueng bkueng bkueng approved these changes

@LorenzMeier LorenzMeier Awaiting requested review from LorenzMeier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagar @bkueng