use NAV_MC_ALT_RAD for MC takeoff check #7380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking a mission, the takeoff altitude is being checked against the waypoint acceptance radius to ensure the MAV being clear from ground before heading to the next waypoint. However, until now the _horizontal_ acceptance radius was being used, instead of the altitude reference value. Targets PX4/Firmware/PX4#7379
|
This is only a quick-fix for multirotors, I'd be happy to hear opinions and work on the fixed wings as well! |
dagar
reviewed
Jun 9, 2017
|
|
||
| // if a specific acceptance radius has been defined, use that one instead |
There was a problem hiding this comment.
Tabs instead of spaces. Usually CI complains about this stuff, but I guess it's lenient on comments.
dagar
previously requested changes
Jun 9, 2017
|
Jenkins test this please. |
|
Travis seems to be stuck somewhere... |
|
@dagar please comment |
dagar
approved these changes
Oct 22, 2017
LorenzMeier
approved these changes
Oct 22, 2017
|
CI was distracting. Need to stabilise it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking a mission, the takeoff altitude is being checked
against the waypoint acceptance radius to ensure the MAV being
clear from ground before heading to the next waypoint.
However, until now the horizontal acceptance radius was being
used, instead of the altitude reference value.
Targets #7379